REQUEST CHANGES — Rules of Hooks violation.

src/app/create/page.tsx:278-281: The two useEffect calls for clearing drafts on publish are placed AFTER the early return at if (!isConnected) return. React hooks must be called in the same order on every render. When isConnected changes from false to true, React will see additional hooks and throw an error. Move these useEffects above the early return, alongside the other hooks.

Minor (non-blocking): discardDraft in useDraft.ts eslint-disables the exhaustive-deps rule and omits currentValues — since it only checks typeof for resetting, this works but is fragile.

Verdict: REQUEST CHANGES

Summary

The autosave hook covers the basic save/restore flow, but the current chain-plot implementation still leaks one storyline's draft into another storyline's storage key.

Findings

• [high] When the chain plot storylineId changes, useDraft re-runs with a new key, but if that new key has no saved draft it just returns early without clearing the previous form state. The old storyline's title / content remain in React state, and the debounced save then writes those stale values into the new storyline-specific key. That breaks the requirement that chain-plot drafts be isolated per storyline.
  • File: src/app/create/page.tsx:186
  • File: src/hooks/useDraft.ts:24
  • File: src/hooks/useDraft.ts:63
  • Suggestion: when the draft key changes and there is no saved draft for that key, reset the bound fields to their empty/default values before the autosave effect can persist the previous storyline's content under the new key.

Decision

Requesting changes because the current implementation can overwrite one storyline's draft with another storyline's content, so the storyline-specific draft behavior is not correct yet.

T2b approves. Rules of Hooks violation fixed — useEffect calls now correctly placed before early return. useDraft hook is clean with proper debounce, restore, and beforeunload handling.

Verdict: APPROVE

Summary

The remaining autosave issues are fixed. The draft hook now resets bound fields when the storyline-specific key changes and no draft exists for the new key, so chain-plot drafts no longer bleed across storylines, and the Rules-of-Hooks issue is already addressed.

Findings

• None.

Decision

Approving because the debounced localStorage autosave, restore/discard flow, beforeunload warning, and storyline-specific draft isolation now satisfy the Batch 26 / #564 requirements.